check

分类: 开发与编程 | 上传者: tw93 | 下载: 0 | 版本: v1.0（最新）

在完成任务、合并之前或代码需要审查时使用。分析结构性问题的差异，直接应用修复，并在声明完成之前用证据进行验证。

更新日志: Source: GitHub https://github.com/tw93/Waza

目录结构

当前层级: tree/main/skills/check/

📄 README.md 730 B
📄 SKILL.md 3.0 KB

SKILL.md

---
name: check
description: Use when completing a task, before merging, or when code needs review. Analyzes the diff for structural issues, applies fixes directly, and verifies with evidence before claiming done.
version: 1.0.0
allowed-tools:
  - Bash
  - Read
  - Edit
  - Write
  - Grep
  - Glob
  - Agent
  - AskUserQuestion
---

# Check: Review Before You Ship

Read the diff, find the problems, fix what can be fixed safely, ask about the rest. Do not claim done until verification has run in this session.

## Get the Diff

```bash
git fetch origin
git diff origin/$(git symbolic-ref --short HEAD 2>/dev/null || echo main)
```

Already on the base branch? Stop and ask which commits to review.

## Did We Build What Was Asked?

Before reading the code, check for scope drift:
- Pull up recent commit messages and any task files
- Does the diff match the stated goal? Flag anything outside that scope: unrelated files, voluntary additions, missing requirements
- Label it: **on target** / **drift** / **incomplete** and note it, but do not block on it

## What to Look For

### Hard stops (fix before merging)

These are not negotiable:

- **Injection and validation**: SQL, command, path injection; inputs that bypass validation at system entry points
- **Shared state**: unsynchronized writes, check-then-act races, missing locks
- **External trust**: output from LLMs, APIs, or user input fed into commands or queries without sanitization; credentials hardcoded or logged
- **Missing cases**: enum or match exhaustiveness; use grep on sibling values outside the diff to confirm

### Soft signals (flag, do not block)

Worth noting but not merge-blocking:

- Side effects that are not obvious from the function signature
- Magic literals that should be named constants
- Dead code, stale comments, style gaps relative to the surrounding code
- Untested new paths
- Loop queries, missing indexes, unbounded growth

## How to Handle Findings

Fix directly when the correct answer is unambiguous: clear bugs, null checks on crash paths, style inconsistencies matching the surrounding code, trivial test additions.

Batch everything else into a single AskUserQuestion when the fix involves behavior changes, architectural choices, or anything where "right" depends on intent:

```
[N items need a decision]

1. [hard stop / signal] What: ... Suggested fix: ... Keep / Skip?
2. ...
```

## Regression Coverage

For every new code path: trace it, check if a test covers it. If this change fixes a bug, a test that fails on the old code must exist before this is done.

## Verification

After all fixes are applied, run the project's own verification command:

```bash
cargo check && cargo test   # Rust
make test / npm test / pytest  # everything else
```

Paste the full output. Report exact numbers. Done means: the command ran in this session and passed.

## Sign-off

```
files changed:    N (+X -Y)
scope:            on target / drift: [what]
hard stops:       N found, N fixed, N deferred
signals:          N noted
new tests:        N
verification:     [command] → pass / fail
```

登录后下载/点赞/收藏 ❤ 648 | ★ 0

check

目录结构

SKILL.md

举报内容

提示