Implementing Cards

Category: Development & Coding | Uploader: bcollazo | Downloads: 0 | Version: v1.0（Latest）
Fill out the implementation of effects of different attacks, abilities, and trainer cards in this Pokemon TCG Pocket engine codebase.
Changelog: Source: GitHub https://github.com/bcollazo/deckgym-core
Directory Structure

Current level: .claude/skills/implement-cards/
📄 SKILL.md 7.5 KB
SKILL.md

---
name: Implementing Cards
description: Fill out the implementation of effects of different attacks, abilities, and trainer cards in this Pokemon TCG Pocket engine codebase.
---

# Implementing Cards

To implement cards, first read the `models` module and the `state` module. Cards
are not implemented if they are a Pokemon that is missing an Ability or Attack implementation,
or a Trainer card (be it a tool or a normal one) missig implementation.

If the user hasn't specified what card to implement, you can use the tool:
  ```bash
  cargo run --bin card_status
  ```
to see what cards are missing, and choose one. You can also that tool
to see what is missing from the specified card.

## Abilities

- Get the details of all the cards that have the ability you want to implement by using the following script:

  ```bash
  cargo run --bin search "Venusaur"
  ```

- Copy the ids of cards to implement (including full art versions) in the given JSON. Only choose the ones with the ability you want to implement.
- Use the new `AbilityMechanic` pathway first.
  - Find the ability effect text in the JSON and search for it in `effect_ability_mechanic_map.rs`.
  - Decide whether to re-use an existing `AbilityMechanic` or add a new variant in `src/actions/abilities/mechanic.rs`.
  - Uncomment all matching `map.insert(...)` lines in `effect_ability_mechanic_map.rs` and map them to the correct `AbilityMechanic` with parameters.
  - Implement the mechanic logic in `forecast_ability_by_mechanic` in `apply_abilities_action.rs`.
    Keep the `match` arms as one-liners (use helpers).
  - Implement move generation logic in `can_use_ability_by_mechanic` in `move_generation_abilities.rs`.
    Keep the `match` arms as one-liners (use helpers).
- If the ability is passive or hook-driven:
  - Prefer a mechanic + hook combo (e.g., hooks in `hooks/core.rs` that apply the effect when damage is calculated).
  - `forecast_ability_by_mechanic` should `panic!` for passive mechanics, and `can_use_ability_by_mechanic` should return `false`.
- Only fall back to `AbilityId` for abilities that cannot yet be represented as a mechanic or need custom one-off logic.
  - If you add `AbilityId`, update both the enum and `ABILITY_ID_MAP` in `ability_ids.rs`, keeping the file ordered by set and number.


## Attack

- Get the details of the card with the attack you want to implement by using the following script:

  ```bash
  cargo run --bin search "Venusaur" --attack "Giant Bloom"
  ```

- Search for the effect text in the above JSON in the `effect_mechanic_map.rs` file.
- Decide if we should introduce a new Mechanic or re-use or generalize an existing one. Try to re-use existing ones first.
- Identify all the cards that have the same effect text template, and just differ by parameters.
- Uncomment all the `// map.insert("` lines that pertain to the mechanic, and add the correct value (an `Mechanic` enum variant with the corresponding parameters).
- Implement the mechanic logic in `forecast_effect_attack_by_mechanic` in `apply_attack_action.rs`.
  - Keep the code as a simple one-liner in the match statement by using helper functions
  - Review similar attacks in `apply_attack_action.rs` to ensure consistency in implementation.

## Tool

- Get the details of the tool card that you want to implement by using the following script:

  ```bash
  cargo run --bin search "Leaf Cape"
  ```

- Copy the ids of cards to implement (including full art versions) in the given JSON.
- In `tool_ids.rs` add the tool to the `ToolId` enum and the `TOOL_ID_MAP` map.
  - Keep the file ordered by set and number.
  - If the tool has attachment restrictions (e.g., only Grass pokémon), implement the `can_attach_to()` method to enforce these restrictions. This counts as the "move generation" for the tool.
- Implement any immediate effects in the tool's core logic rather than a dedicated "on attach" hook.
  - For HP modifiers, prefer dynamic calculation in `PlayedCard::get_effective_total_hp()`.
  - For other immediate effects, add a focused helper in the relevant hook file and call it from the appropriate action handler.
- Implement the "forecast action" logic in `forecast_trainer_action` in `apply_trainer_action.rs`.
  - Add the tool's CardId to the match branch that calls `doutcome(attach_tool)`.
  - Tools should be grouped together in a single match arm (e.g., `CardId::A2147GiantCape | CardId::A2148RockyHelmet | CardId::A3147LeafCape`).
- For tools with ongoing effects (not just on-attach):
  - Implement hooks in `hooks/core.rs` or other appropriate hook files.
  - Examples: Rocky Helmet deals damage when the holder is attacked.

## Trainer Cards

- Get the details of the trainer card that you want to implement by using the following script:

  ```bash
  cargo run --bin search "Rare Candy"
  ```

- Copy the ids of cards to implement (including full art versions) in the given JSON.
- Implement the "move generation" logic.
  - In `move_generation_trainer.rs` implement the switch branch. Its often the case the Trainer/Support can always be played, so just add to this case in the switch.
- Implement the "apply action" logic.

  - This is the code that actually runs when the card is played.
  - Visit `apply_trainer_action.rs`.
  - Often its just "applying an effect" in the field (like Leaf).

    - If the turn is something that affects all pokemon in play for a given turn use
      the `.turn_effects` field in the state. You can use to for effects that apply to
      this turn, or a future one.
    - Some cards might be fairly unique and might need architectural changes to the engine. For cards with considerable custom logic,
      try to find a generalizing pattern that can be presented as a "hook" in the `hooks.rs`. The idea of `hooks.rs` is to try to encapsulate
      most custom logic that goes outside of the normal business logic. Also consider adding new
      pieces of state to the `State` struct if necessary.

  - Try to keep the `match trainer_id` cases as one-liners (using helper functions if necessary).

## Stadium

- Get the details of the stadium card that you want to implement by using the following script:

  ```bash
  cargo run --bin search "Peculiar Plaza"
  ```

- Copy the ids of cards to implement (including full art versions) in the given JSON.
- In `stadiums.rs`:
  - Add a static `LazyLock<String>` constant for the stadium's effect text.
  - Add the stadium to `is_stadium_effect_implemented()`.
  - Add a helper function to query the stadium's effect (e.g., `get_peculiar_plaza_retreat_reduction`).
- Add Stadium move generation:
  - Move generation is already handled generically in `move_generation_trainer.rs` via `can_play_stadium()`.
  - No per-stadium logic needed unless the stadium has unique play conditions.
- Hook the stadium effect into the appropriate game mechanic:
  - Retreat cost effects: `hooks/retreat.rs` in `get_retreat_cost()`
  - Damage bonuses: `hooks/core.rs` in `modify_damage()`
  - HP bonuses: May need to modify `get_effective_total_hp()` or damage calculation
- Stadium effects apply to BOTH players equally.
- Test using `cargo run --bin card_test -- "CardId"`.

## Appendix

### Testing Your Implementation

After implementing a card test it like so:

Run the integrated card test command (it generates a temp deck and runs 10,000 random games against all decks in `example_decks/`):

```bash
cargo run --bin card_test -- "Card ID"
```

Review the results to ensure the games complete without errors.

### Code Quality

Make sure to run `cargo clippy --fix --allow-dirty -- -D warnings` and `cargo fmt` to format the code. Also make sure `cargo test --features tui` still work.
Comments 0
Latest | Hot
Please login before commenting.
No comments yet. Be the first one!
Implementing Cards

Directory Structure

SKILL.md

Report

Notice
