code_review

分类: 开发与编程 | 上传者: krishnakanthb13 | 下载: 0 | 版本: v1.0（最新）

Comprehensive code review covering Functionality, Security (OWASP), Performance, and Maintainability. Includes good/bad examples.

更新日志: Source: GitHub https://github.com/krishnakanthb13/antigravity_global_skills

目录结构

当前层级: code_review/

📄 SKILL.md 2.6 KB

SKILL.md

---
name: code_review
description: Comprehensive code review covering Functionality, Security (OWASP), Performance, and Maintainability. Includes good/bad examples.
---

# Code Review Checklist

Use this skill to conduct a thorough, senior-level code review.

## Inputs
*   **Target**: The file or directory to review.
*   **Focus**: (Optional) Specific area to check (e.g., security, performance).

## Tooling Strategy
*   Use `view_file` to read the code.
*   Use `grep_search` if looking for specific patterns across multiple files.

## Workflow

### 1. Functionality & Logic (The "Does it Work?" Check)
*   **Requirements**: Does this solving the stated problem?
*   **Edge Cases**: Nulls, empty states, limits (min/max).
*   **Error Handling**: Are errors caught, logged, and handled gracefully (no silent failures)?

### 2. Security (The OWASP Check)
*   **Injection**: Check for raw SQL, `innerHTML`, or `eval()`.
    *   *❌ Bad*: `db.query("SELECT * FROM users WHERE name = " + input)`
    *   *✅ Good*: `db.query("SELECT * FROM users WHERE name = $1", [input])`
*   **Secrets**: Ensure NO API keys or passwords are committed. (Use `.env`).
*   **Auth**: Are permission checks present on sensitive routes?

### 3. Performance (The Scalability Check)
*   **Loops**: No expensive operations inside loops (e.g., DB calls).
*   **N+1 Problems**: Check for fetching data in a loop instead of batches.
*   **Memory**: Are listeners/connections cleaned up?

4. **Code Quality (The Maintainability Check)**
*   **Naming**: Variables should be intentional (`isValid` vs `v`).
*   **DRY (Don't Repeat Yourself)**: Can distinct logic be extracted to a helper?
*   **SOLID Principles**:
    *   **S**: Does the class/function do only ONE thing?
    *   **O**: Can we add features without changing this code?
    *   **L**: Can subclasses be used interchangeably?
    *   **I**: Are interfaces too bloated?
    *   **D**: Is it hard-coded to a specific implementation? (Use dependency injection).
*   **Comments**: Explain *WHY*, not *WHAT*.

### 5. Git & Hygiene
*   **Commits**: Are they atomic and descriptive?
*   **Leftovers**: No `console.log` (debug only), commented-out code, or TODOs without an issue tracking them.

## Output Format
Structure your review like this:

**Summary**: [High level opinion - Ready to Merge / Changes Requested]

| Category | Status | Notes |
| :--- | :--- | :--- |
| **Functionality** | ✅ / ⚠️ | ... |
| **Security** | ✅ / 🔴 | ... |
| **Performance** | ✅ / ⚠️ | ... |

**Detailed Comments**:
*   [File/Line]: [Issue description]
    *   *Suggestion*: [Code snippet check]

登录后下载/点赞/收藏 ❤ 18 | ★ 0

code_review

目录结构

SKILL.md

举报内容

提示