xp-accept

Category: Tools & Productivity | Uploader: paulingalls | Downloads: 0 | Version: v1.0（Latest）
Changelog: Source: GitHub https://github.com/paulingalls/xp-agents
Directory Structure

Current level: tree/main/plugins/xp-agents/skills/xp-accept/
📁 scripts/
- 📄 acceptance_types.py 1.6 KB
- 📄 concern_triage.py 3.4 KB
- 📄 preload.sh 1.5 KB
📄 SKILL.md 5.7 KB
SKILL.md

---
name: xp-accept
description: >-
  Verify acceptance criteria for in-progress stories. Present criteria,
  guide e2e test execution, mark stories done or deferred, update sprint.json.
allowed-tools:
  - Read
  - Bash
  - Bash(*/append.sh *)
  - Bash(*/init.sh)
  - Bash(*/skills/*/scripts/*)
  - Bash(python3 */scripts/branching.py *)
---

!`CLAUDE_PLUGIN_DATA="${CLAUDE_PLUGIN_DATA}" ${CLAUDE_SKILL_DIR}/scripts/preload.sh`

# Accept Verification

The preload above shows sprint state: in-progress count + `SPRINT_FILE=<path>`, or ERROR/NO_IN_PROGRESS.

**If ERROR or NO_IN_PROGRESS**, explain and stop.

## Step 0: Cross-Teammate Review (if TEAMMATE_WORKTREES shown)

If the preload shows **TEAMMATE_WORKTREES**, teammate branches were merged. Run a cross-teammate review cycle on the merged code:

1. `/simplify` scoped to merged teammate changes (use `args: "the merged teammate changes since before the teammate merges"`)
2. `/xp-quality-review` — check for drift and inter-story debt
3. `/security-review` scoped to merged teammate changes (use `args: "the merged teammate changes since before the teammate merges"`)

Skip if no TEAMMATE_WORKTREES section.

## Step 1: Review Each In-Progress Story

Read the sprint file at `SPRINT_FILE`. For each in-progress story, check its `acceptance_execution` field (the preload's `### Acceptance Types` section shows the type per story for quick reference):

### Automated acceptance (type != "manual")

When `acceptance_execution` is present and `type` is not `"manual"`:

1. Present the story title and acceptance criteria.
2. If `acceptance_execution.setup` is present, run it first via Bash.
3. Run `acceptance_execution.command` via Bash.
4. **Exit code 0 = pass.** Report success, proceed to mark done.
5. **Non-zero exit = fail.** Show the output and ask via `AskUserQuestion`:
   - **Debug and re-run** — investigate the failure, fix the cause, then re-run the command
   - **Override with concern** — mark as passing despite failure. Requires a reason string. Records a `concern` event:
     ```bash
     ${CLAUDE_PLUGIN_ROOT}/smm/append.sh --smm-dir <SMM_DIR> \
       --type "concern" --agent "xp-accept" --severity "medium" \
       --content "Acceptance override for story-NNN: <user's reason>"
     ```
   - **Defer** — move story to `deferred` with a reason

Do **not** retry automatically. Flaky acceptance is information — fix the harness, don't mask the signal.

### Manual acceptance (type = "manual" or no acceptance_execution)

When `acceptance_execution` is absent or `type` is `"manual"`:

1. Present the story title and all acceptance criteria.
2. For each **E2E criterion** (prefixed "E2E:") — run the test via Bash. Report results.
3. For **non-E2E criteria** — ask the user to verify.
4. Ask via `AskUserQuestion`: "Mark **story-NNN** as `done` or `deferred`?"
   - **done** — all acceptance criteria verified and passing
   - **deferred** — incomplete, carry forward to next sprint
5. Resolve any user questions before marking.

## Step 1b: Concern Triage

If the preload shows `### Concerns for story-NNN`, review each listed concern against the story's work. For each concern, judge whether the story's commits address it:

- **If clearly addressed** — resolve it:
  ```bash
  ${CLAUDE_PLUGIN_ROOT}/smm/append.sh --smm-dir <SMM_DIR> \
    --type "status" --agent "xp-accept" \
    --content "Story story-NNN addresses concern: <brief reason>" \
    --working-on '[]' --metadata '{"resolves": ["<concern-id>"]}'
  ```
- **If unsure** — leave it open for manual triage at next work-selection.

File overlap alone does not mean a concern is resolved. Use your judgment based on the concern's content and what the commits actually changed.

## Step 2: Update sprint.json

Update each story's status via CLI:

```bash
python3 ${CLAUDE_PLUGIN_ROOT}/smm/sprint_cli.py --smm-dir <SMM_DIR> \
  update-story story-NNN <done|deferred>
```

## Step 2b: Merge Story Branches

Read the branching stage once:
```bash
python3 ${CLAUDE_PLUGIN_ROOT}/scripts/branching.py --smm-dir <SMM_DIR> stage
```

If stage >= 1, get the merge target branch:
```bash
python3 ${CLAUDE_PLUGIN_ROOT}/scripts/branching.py --smm-dir <SMM_DIR> \
  get-base --cwd .
```

Merge each story marked **done** into the base branch. Branch names follow `<user>/story-NNN-<slug>` — check `git branch` to find the exact name.

```bash
python3 ${CLAUDE_PLUGIN_ROOT}/scripts/branching.py --smm-dir <SMM_DIR> \
  merge --cwd . --branch <story-branch-name> --target <base-branch>

python3 ${CLAUDE_PLUGIN_ROOT}/scripts/branching.py --smm-dir <SMM_DIR> \
  delete --cwd . --branch <story-branch-name>
```

If merge fails (conflict or error), report the failure and skip that story's branch deletion. Do not proceed to delete a branch whose merge failed.

**Stage 0 or missing:** Skip merge and cleanup entirely.
**Deferred stories:** Do not merge — leave their branches intact for the next sprint.

## Step 3: Record Events

For each story disposition:
```bash
${CLAUDE_PLUGIN_ROOT}/smm/append.sh --smm-dir <SMM_DIR> \
  --type "status" --agent "xp-accept" \
  --content "Story story-NNN marked <done|deferred>: <brief reason>" \
  --working-on '[]'
```

## Step 4: Summary

Present: how many stories marked done, how many deferred.

## Step 5: Cleanup Teammate Worktrees (if TEAMMATE_WORKTREES shown)

For each **done** story's worktree:

```bash
python3 ${CLAUDE_PLUGIN_ROOT}/scripts/cleanup_teammate.py \
  --name teammate-story-NNN --smm-dir <SMM_DIR>
```

Verifies branch is merged before removing worktree, branch, markers, and report. **Only cleanup done stories** — leave deferred worktrees intact. If cleanup fails (unmerged commits), report and skip.

## Step 6: Sprint Review

**If all stories are now done or deferred**, the sprint is complete. Run `/xp-sprint-review` immediately — do not wait for the stop gate.
Comments 0
Latest | Hot
Please login before commenting.
Loading comments...
xp-accept

Directory Structure

SKILL.md

Report

Notice
